Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle null being passed to createTransformer #9955

Merged
merged 2 commits into from
May 3, 2020
Merged

fix: handle null being passed to createTransformer #9955

merged 2 commits into from
May 3, 2020

Conversation

yinm
Copy link
Contributor

@yinm yinm commented May 3, 2020

Summary

I took a regression bug in babel-jest.
The regression bug occurs since bb720d2#diff-ad0be0b5e1f4711c408a42bdbea512bcR43-R57 .

fixes #9926

@facebook-github-bot
Copy link
Contributor

Hi @yinm!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@yinm yinm marked this pull request as ready for review May 3, 2020 05:52
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #9955 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9955      +/-   ##
==========================================
- Coverage   64.08%   64.06%   -0.02%     
==========================================
  Files         293      293              
  Lines       12457    12457              
  Branches     3069     3067       -2     
==========================================
- Hits         7983     7981       -2     
- Misses       3832     3833       +1     
- Partials      642      643       +1     
Impacted Files Coverage Δ
packages/babel-jest/src/index.ts 51.42% <100.00%> (ø)
packages/expect/src/utils.ts 94.96% <0.00%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a3c997...f4d8232. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yinm, this is great! I've only got a nit for the changelog, code and test LGTM 👍

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Simen Bekkhus <[email protected]>
@yinm
Copy link
Contributor Author

yinm commented May 3, 2020

Thank you for the review 🙏
I incorporated your suggestion, so please check it.

@SimenB SimenB changed the title fix: take a regression bug for createTransformer fix: handle null being passed to createTransformer May 3, 2020
@SimenB SimenB merged commit 2e8f8d5 into jestjs:master May 3, 2020
@SimenB
Copy link
Member

SimenB commented May 3, 2020

Thanks @yinm!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A bug?
4 participants