[build] rework tox, PEP-518, pre-commit and more #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Required by the following tests: * attribute/test_rule_500.py * ieee/test_rule_500.py Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Alon Bar-Lev <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1149 +/- ##
==========================================
- Coverage 96.49% 94.01% -2.48%
==========================================
Files 1550 1557 +7
Lines 29321 29028 -293
Branches 0 3414 +3414
==========================================
- Hits 28292 27291 -1001
- Misses 1029 1303 +274
- Partials 0 434 +434 ☔ View full report in Codecov by Sentry. |
|
It looks like GitHub gives me three options to merge:
I was reading this documentation on the rebase: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/about-merge-methods-on-github This section seems to indicate it is better to do a rebase locally: so I will follow your instructions. |
jeremiah-c-leary
merged commit baf22da
into
jeremiah-c-leary:master
11 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jeremiah-c-leary,
A reopen of #1141 to ease merge using GitHub if this what you prefer.
Please make sure that github merge does not lose the history.
Thanks,