Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssh-agent usage example #74

Merged
merged 2 commits into from
Jul 17, 2017
Merged

Add ssh-agent usage example #74

merged 2 commits into from
Jul 17, 2017

Conversation

orevial
Copy link
Contributor

@orevial orevial commented Jul 17, 2017

Just added a small example of ssh-agent usage for Git push

Just added a small example of ssh-agent usage for Git push
@daniel-beck
Copy link
Member

Is git-credentials the ID of these credentials? If so, should be made explicit (or show a UUID instead to be super clear it's an ID).

@orevial
Copy link
Contributor Author

orevial commented Jul 17, 2017

Yes it is the ID of the SSH credentials. What would you put as the credentials ID ? "git-ssh-UUID" ? Tell me and I'll change the code accordingly.

@daniel-beck
Copy link
Member

Well, git-credentials-ID would be a solid improvement already. Change the previous use (credentialsId: MyID) accordingly for consistency and it should be clear enough IMO.

@orevial
Copy link
Contributor Author

orevial commented Jul 17, 2017

Hmm I'm not sure we want to use the same Id in both examples because it could be confusing to read twice the same Id for different use cases (username/password and SSH)

@orevial
Copy link
Contributor Author

orevial commented Jul 17, 2017

I've modified both credentialsId, I'll let you judge if that's fine for you.

@rtyler rtyler merged commit 2367842 into jenkinsci:master Jul 17, 2017
@daniel-beck
Copy link
Member

@orevial Thank you!

@orevial orevial deleted the patch-1 branch July 18, 2017 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants