fix(gokrb5.config): do not panic on auth_to_local* #550
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2024 13:56
Extended: Also improve error reporting when we encounter incomplete parser situations. Now, if we are in an unhandled parser situation, we will return an explicit error instead of panicking on an IndexError. Previous situation: passing an "auth_to_local" directive caused a Panic when doing v := strings.TrimSpace(p[1])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth_to_local* directives are still not supported, but that's not a good reason to panic when we encounter them. Now we will just explicitly ignore them.
Also improve error reporting in general when we encounter incomplete parser situations. Now, if we are in an unhandled parser situation, we will return an explicit error instead of panicking on an IndexError.
Previous situation: passing an "auth_to_local" directive caused a Panic when doing v := strings.TrimSpace(p[1])
Now we are just explicitly saying we do not support that which is objectively better.
When we encounter an unsupported configuration directive and the parser reaches an incorrect state, we will report the error and output the config. There's a good chance that the latest configuration directive put is the unsupported one. This way, we can easily fix such mistakes when they come in issues.