Treat upstream internal server errors as temporary failures (closes #336) #337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, we were treating upstream internal server errors as permanent rejections. This change introduces a special case for internal server errors so that they'll be treated as temporary write failures (i.e. write futures will fail with an
ApnsServerException
) instead of permanent rejections (i.e. a successful future with aPushNotificationResponse
that reportsisRejected
astrue
).