Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EAP 6.4] Update build for new repo configs and increase the timeout needed to clean up after patching #49

Merged

Conversation

luck3y
Copy link
Collaborator

@luck3y luck3y commented Jan 8, 2019

Signed-off-by: Ken Wills [email protected]

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request contains description of the issue
  • Pull Request does not include fixes for other issues
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <[email protected]> - use git commit -s

@luck3y luck3y self-assigned this Jan 8, 2019
@luck3y luck3y changed the title Update 6.4 build for new repo configs and increase the timeout needed to clean up after patching [EAP 6.4] Update build for new repo configs and increase the timeout needed to clean up after patching Jan 9, 2019
@bstansberry
Copy link
Collaborator

What's the JIRA for this timeout change? 180 secs seems like a very long time.

The timeout change vs the build eye of newt stuff seem like distinct issues.

@luck3y
Copy link
Collaborator Author

luck3y commented Jan 14, 2019

@bstansberry There isn't one, I can make one though. They are somewhat distinct, but I can't successfully run a build of this on my machine with the default timeout, it always exceeds it. OSBS, on the other hand, it works fine.

@bstansberry
Copy link
Collaborator

@luck3y OK, I wasn't thinking right. This timeout is just part of the image build, it's not a runtime timeout. So I'm not particularly concerned about a JIRA for it.

180 secs seems really long though, particularly for a shutdown.

@luck3y
Copy link
Collaborator Author

luck3y commented Jan 14, 2019

Yeah, the value is somewhere > 30 and < 180, but given that its likely just my machine being slow, picking an actual number didn't seem to make much sense. Actually on the shutdown, its probably not needed, so I can probably reset that to 30s again.

@luck3y luck3y merged commit d5382d4 into jboss-container-images:eap64-dev Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants