Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor training #158

Merged
merged 5 commits into from
May 22, 2024
Merged

Refactor training #158

merged 5 commits into from
May 22, 2024

Conversation

jbloomAus
Copy link
Owner

Description

Mostly refactoring work with no functional changes:

  • some cleaning up of previous regressions (not saving as much in our checkpoints)
  • moving towards better abstractions / boundaries but not finished (more changes coming, but likely won't touch the high level api again this week).
  • updated docs to clean up a little bit and remove stale code. Still work to do.

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 59.30736% with 94 lines in your changes are missing coverage. Please review.

Project coverage is 66.96%. Comparing base (cf94845) to head (2282f5b).

Files Patch % Lines
sae_lens/training/train_sae_on_language_model.py 72.72% 29 Missing and 10 partials ⚠️
sae_lens/training/lm_runner.py 28.57% 35 Missing ⚠️
sae_lens/training/checkpointing.py 20.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   67.31%   66.96%   -0.36%     
==========================================
  Files          18       19       +1     
  Lines        1802     1704      -98     
  Branches      284      266      -18     
==========================================
- Hits         1213     1141      -72     
+ Misses        523      506      -17     
+ Partials       66       57       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbloomAus jbloomAus merged commit 72179c8 into main May 22, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant