Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use '==' for comparison against empty string instead of 'is' #20

Merged
merged 1 commit into from
Jan 15, 2014
Merged

use '==' for comparison against empty string instead of 'is' #20

merged 1 commit into from
Jan 15, 2014

Conversation

marconi
Copy link
Contributor

@marconi marconi commented Jan 15, 2014

Using is matches not just the string value but also the type so it doesn't match a unicode empty string u"".

@jleclanche
Copy link
Member

Good catch, thanks.

jleclanche pushed a commit that referenced this pull request Jan 15, 2014
Merge pull request #20 from marconi/master
564e4a7 
use '==' for comparison against empty string instead of 'is'
@jleclanche jleclanche merged commit 564e4a7 into jazzband:master Jan 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marconi @jleclanche