Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inaccurate disk size on windows #325

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

sspring
Copy link

@sspring sspring commented Jul 16, 2022

wmi report inaccurate disk size, refer : https://stackoverflow.com/questions/9901792/wmi-win32-diskdrive-to-get-total-sector-on-the-physical-disk-drive
replace Win32_DiskDrive with DeviceIOControl.

wmi report inaccurate disk size, refer : https://stackoverflow.com/questions/9901792/wmi-win32-diskdrive-to-get-total-sector-on-the-physical-disk-drive  
replace Win32_DiskDrive with DeviceIOControl.
@ffromani
Copy link
Collaborator

thanks for this contribution @sspring ! could you please add a unit test to ensure this code doesn't regress? None of the active main contributors is a windows user, so this is especially important, as we rely on CI for correctness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants