-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.3/5.0 broken on Node.js with Typescript: WebSocket is not defined #385
Comments
Looks like this breaking change was actually introduced in a minor bump |
I have the same problem! node_modules/graphql-request/dist/graphql-ws.d.ts:19:25 - error TS2304: Cannot find name 'WebSocket'. 19 constructor(socket: WebSocket, { onInit, onAcknowledged, onPing, onPong }: SocketHandler); Found 1 error(s). I fixed for now with "skipLibCheck": true In tsconfig.json |
same Issue here |
Yes, this is a problem. We need to be able to use |
|
This is still an issue. Bump |
WebSocket
functionality was introduced in #330 but assumed thatWebSocket
was available everywhere. This is only the case in the DOM - Node does not haveWebSocket
available in the global scope. This makes typescript compilation fail in all cases.Reference comment (cc @SimenB):
#330 (comment)
The text was updated successfully, but these errors were encountered: