Skip to content

Commit

Permalink
windows: correct outputs list in "node_etw" gyp target
Browse files Browse the repository at this point in the history
The gyp target node_etw didn't list its output dependencies. This
was causing virgin builds to fail with a "failed to open file for
write" error.

With this corrected outputs list, gyp reliably pre-creates
required output directories.
  • Loading branch information
sblom authored and piscisaureus committed Oct 29, 2012
1 parent 9b61f57 commit 953b049
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,11 @@
{
'action_name': 'node_etw',
'inputs': [ 'src/res/node_etw_provider.man' ],
'outputs': [ '<(SHARED_INTERMEDIATE_DIR)' ],
'action': [ 'mc <@(_inputs) -h <@(_outputs) -r <@(_outputs)' ]
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/node_etw_provider.rc',
'<(SHARED_INTERMEDIATE_DIR)/node_etw_provider.h',
],
'action': [ 'mc <@(_inputs) -h <(SHARED_INTERMEDIATE_DIR) -r <(SHARED_INTERMEDIATE_DIR)' ]
}
]
} ]
Expand Down

0 comments on commit 953b049

Please sign in to comment.