Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of underscorejs.org TOC #2568

Merged
merged 1 commit into from
Jul 21, 2016

Conversation

ben-joostens
Copy link
Contributor

The TOC section has the following CSS:

ul.toc_section {
    font-size: 11px;
    line-height: 14px;
    margin: 5px 0 0 0;
    padding-left: 0px;
    list-style-type: none;
    font-family: Lucida Grande;
}

Since Lucida Grande is/might be missing on default installs, the result is a tiny serif font being used. It is also superfluous as it is already declared with a proper fall-back, here:

.interface {
    font-family: "Lucida Grande", "Lucida Sans Unicode", Helvetica, Arial, sans-serif !important;
}

Example:

screenshot-underscorejs org 2016-07-14 22-55-55

Simply removing font-family from that block would solve the issue, though I've increased the font-size slightly since 11px is tiny no matter what font is used.

@megawac megawac merged commit 6fa3796 into jashkenas:master Jul 21, 2016
@captbaritone
Copy link
Collaborator

Seems kinda unbalanced to my eye, but maybe I'm just used to the old look...

screen shot 2016-07-21 at 1 42 21 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants