ata: ahci: fix memory leak

malloc(..) and memalign(..) are both allocating memory and as a result we leak the memory allocated with malloc(..). Signed-off-by: Christian Gmeiner <[email protected]> Reviewed-by: Simon Glass <[email protected]>
jannau · May 9, 2019 · 28b4ba9 · 28b4ba9
1 parent 3a90b50
commit 28b4ba9
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
@@ -571,15 +571,12 @@ static int ahci_port_start(struct ahci_uc_priv *uc_priv, u8 port)
 		return -1;
 	}
 
-	mem = malloc(AHCI_PORT_PRIV_DMA_SZ + 2048);
+	mem = memalign(2048, AHCI_PORT_PRIV_DMA_SZ);
 	if (!mem) {
 		free(pp);
 		printf("%s: No mem for table!\n", __func__);
 		return -ENOMEM;
 	}
-
-	/* Aligned to 2048-bytes */
-	mem = memalign(2048, AHCI_PORT_PRIV_DMA_SZ);
 	memset(mem, 0, AHCI_PORT_PRIV_DMA_SZ);
 
 	/*