-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replaced lambda
expressions with def
functions
#27738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there are some lint failures that are happening, can you fix those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fully sure if we should be replacing all lambda functions by def
(espectially the ones that are simple like lambda x: isinstance(x, bool)
), what do you think @KareemMAX? Thanks for creating the PR @Sai-Suraj-27 😄
@KareemMAX, The lint is failing because the |
I don't think it will hurt, the functions will have equivalent AST after all. Unless you prefer lambdas from a readability/writability point of view |
PR Description
I see that, at few places in the codebase, a
lambda
expression is being used instead of adef
. I found all the places where this is happening using theruff
tool, and replaced all of those lambda expressions with adef
function.Related Issue
Closes #
Checklist
Socials