Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added divide method in the PyTorch frontend #21753

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Added divide method in the PyTorch frontend #21753

merged 3 commits into from
Aug 17, 2023

Conversation

he11owthere
Copy link
Contributor

closes #21752

image

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 12, 2023
@he11owthere
Copy link
Contributor Author

@AlexandraPosta Please add 'bfloat16' in the with_unsupported_dtypes decorator before running the tests until the issue with ivy.Array.repr method has been fixed as mentioned by Ved in #21447. Thank you! 🙂

@AlexandraPosta
Copy link
Contributor

Hello! Please have another look at the parameters for the test function.

@he11owthere
Copy link
Contributor Author

Hello! Please have another look at the parameters for the test function.

Hello @AlexandraPosta! Thank you for your input. I've reviewed the parameters for the test function once more, and everything appears to be in order with my code. If you have any further suggestions or concerns, please let me know. 😊

@AlexandraPosta
Copy link
Contributor

Apologies about that. I must have read something wrong. Thank you for your contribution!

@AlexandraPosta AlexandraPosta merged commit efb65ca into ivy-llc:main Aug 17, 2023
76 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

divide
3 participants