-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable MCP by default in helm values and e2e tests #10222
Conversation
We'll also need the following changes:
|
…se the non-mcp variants
See istio/istio#10222 for the corresponding istio/istio change.
cc @hklai, all tests are green now. Once this is merged, we can merge istio/test-infra#1077 and then create a follow-up PR in istio/istio to remove the *-mcp.sh variants. |
why do we need to run 2x in circleci? can't we simply test only with mcp? |
How about we run non mcp in circle periodic only? |
Done - circleci non-MCP tests are only run periodically. The prow tests will be updated in a follow-up test-infra PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ayj, hklai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ayj: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* enable mcp by default in test framework and top-level help charts * invert mcp and non-mcp circleci tests * invert prow mcp and non-mcp tests * temporarily add mcp specific tests back while we transition prow to use the non-mcp variants * remove non-mcp circleci tests from presubmit (cherry picked from commit 970e079)
* update prow to use the new non-mcp test names See istio/istio#10222 for the corresponding istio/istio change. * update mandatory circleci tests * remove non-mcp prow tests from presubmit * remove non-mcp circle tests from mandatory status checks
Enable MCP by default in helm values and e2e tests (#10222)
* update prow to use the new non-mcp test names See istio/istio#10222 for the corresponding istio/istio change. * update mandatory circleci tests * remove non-mcp prow tests from presubmit * remove non-mcp circle tests from mandatory status checks
This PR inverts the default helm options so that MCP is enabled by default. For the time being users can still disable MCP to compare performance and functional behavior with MCP.
The MCP and non-MCP e2e tests have also been inverted so that the full test suite now runs with MCP enabled. A subset of e2e tests are run w/o MCP as a reference for flakiness.