Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): also test with Node.js 10 #17

Closed
wants to merge 2 commits into from

Conversation

shinnn
Copy link
Collaborator

@shinnn shinnn commented Apr 18, 2019

To test this line

const cjsWrapperLength = isNode10 ? require('module').wrapper[0].length : 0
and get 100% code coverage

@coveralls
Copy link

coveralls commented Apr 18, 2019

Pull Request Test Coverage Report for Build 54

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.1%) to 95.318%

Totals Coverage Status
Change from base Build 53: -3.1%
Covered Lines: 234
Relevant Lines: 235

💛 - Coveralls

@bcoe
Copy link
Member

bcoe commented Apr 18, 2019

@shinnn I don't believe Node 10 will pass until we land:

nodejs/node#27124

In Node.js, perhaps add your vote to that backport 😄

@shinnn
Copy link
Collaborator Author

shinnn commented Apr 18, 2019

Thanks for the link. Closing for now.

@shinnn shinnn closed this Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants