Skip to content

Commit

Permalink
Make pltcl regression tests safe for Danish locale.
Browse files Browse the repository at this point in the history
Another peculiarity of Danish locale is that it has an unusual idea
of how to sort upper vs. lower case.  One of the pltcl test cases has
an issue with that.  Now that COLLATE works in all supported branches,
we can just change the test to be locale-independent, and get rid of
the variant expected file that used to support non-C locales.
  • Loading branch information
tglsfdc committed Jul 21, 2016
1 parent b3399cb commit 95810ed
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 309 deletions.
4 changes: 2 additions & 2 deletions src/pl/tcl/expected/pltcl_queries.out
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ select 100 @< 4;
f
(1 row)

select * from T_pkey1 order by key1 using @<, key2;
select * from T_pkey1 order by key1 using @<, key2 collate "C";
key1 | key2 | txt
------+----------------------+------------------------------------------
1 | KEY1-3 | should work
Expand All @@ -174,7 +174,7 @@ select * from T_pkey1 order by key1 using @<, key2;
2 | key2-9 | test key
(6 rows)

select * from T_pkey2 order by key1 using @<, key2;
select * from T_pkey2 order by key1 using @<, key2 collate "C";
key1 | key2 | txt
------+----------------------+------------------------------------------
1 | KEY1-3 | test key
Expand Down
305 changes: 0 additions & 305 deletions src/pl/tcl/expected/pltcl_queries_1.out

This file was deleted.

4 changes: 2 additions & 2 deletions src/pl/tcl/sql/pltcl_queries.sql
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ select tcl_sum(key1) from T_pkey1 where key1 = 99;
select 1 @< 2;
select 100 @< 4;

select * from T_pkey1 order by key1 using @<, key2;
select * from T_pkey2 order by key1 using @<, key2;
select * from T_pkey1 order by key1 using @<, key2 collate "C";
select * from T_pkey2 order by key1 using @<, key2 collate "C";

-- show dump of trigger data
insert into trigger_test values(1,'insert');
Expand Down

0 comments on commit 95810ed

Please sign in to comment.