Force using POSIX shell in extpkg.cl script #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some shells behave differently; namely zsh prints a warning itself
when a glob doesn't match. This is f.e. the case when one tries to
get the list of external packages from an empty dir with
/bin/ls -1ad [a-y]* 2> /dev/null
With zsh, this leads to a message "no matches found" which disturbs
f.e. the tests.
The solution is to use git add unix/hlib/extpkg.cl in
the cl script so that /bin/sh is forced to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some shells behave differently; namely zsh prints a warning itself when a glob doesn't match. This is f.e. the case when one tries to get the list of external packages from an empty dir with
iraf/unix/hlib/extpkg.cl
Line 26 in bcb80b3
With zsh, this leads to a message "no matches found" which disturbs f.e. the tests. See f.e. #178 (reply in thread) for such a failure.
The solution is to use
!!in the cl script so that/bin/shis forced to be used. Generally, the scripts provided by IRAF should be independent of the user's shell (just checked that this is the only place where this happens).