Consolidated TraitType Defaults Into One Generator #349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #344
TraitType.default
which acts exactly like the methods defined by@default
.@default
to help indicate this.Union
defaults defined by "subtraits".Note
TraitType.default
could be built intomake_dynamic_default
by extending its signature, but I'm slightly averse to this idea simply for the sake of uniformity betweenTraitType.default
and@default
, and the fact that the namemake_dynamic_default
is now redundant. If we choose to preferdefault
tomake_dynamic_default
, then the functionality ofmake_dynamic_default
will be redundant too and would be on a track towards deprecation.