This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
improve dockerfiles #4275
Closed
improve dockerfiles #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
reviewed
Jan 6, 2023
|
worth mentioning, probably, that this configuration removes the package manager, apk, so, it would be impractical to build containers out of this one. I think it's appropriate to remove i if the container is not explicitly a base layer for other stuff, but it's up to you guys. |
|
contains a bug where will always init because $IPFS_PATH is not a file, change to -d or point to PATH/config |
|
Thank you so much for opening this PR and for your patience in getting it merged. js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide. Sorry we never got to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve dockerfiles by removing unnecessary layers and greatly reducing size.
remove sed line that causes insecure exposure -- users must use proper configs.
adds a proper init, catatonit, selected for modern signal handling.