Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(select): set the default justify-content as a style #29804

Merged
merged 5 commits into from
Aug 29, 2024
Merged

refactor(select): set the default justify-content as a style #29804

merged 5 commits into from
Aug 29, 2024

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Aug 26, 2024 •
edited
Loading

Issue number: internal

What is the current behavior?

The justify property in ion-select defaults to space-between.

What is the new behavior?

  • Remove the default property value in favor of setting the default style in the CSS to match the other form controls.
  • Updates the e2e test for label to remove the explicit width & add more examples with long labels and a default select without justify set.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vercel Vercel
Copy link

vercel bot commented Aug 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 1:53pm

@github-actions github-actions bot added the package: core @ionic/core package label Aug 26, 2024
@brandyscarney brandyscarney marked this pull request as ready for review August 28, 2024 21:36
@brandyscarney brandyscarney requested a review from a team as a code owner August 28, 2024 21:36
thetaPC
thetaPC approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney merged commit 33fd894 into feature-8.3 Aug 29, 2024
46 checks passed
@brandyscarney brandyscarney deleted the ROU-11045 branch August 29, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandyscarney @thetaPC