removed if else block from function.js #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakesh-chinta
pushed a commit
that referenced
this pull request
May 17, 2017
Improved Twitter Search Feature
rakesh-chinta
approved these changes
May 17, 2017
MaxReinisch
pushed a commit
that referenced
this pull request
Jul 24, 2019
Merge pull request #374 from Zerichen/hyperlink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr aims to resolve #3 issue , it directly calls respective funtions from button listeners and avoids going through the if else block in function.js as this if else block fails sometimes like when recent/first version buttons are clicked after clicking save button(which opens new tab) , then one more tab for save button opens up because save_now variable remains equal to 1 .