This repository has been archived by the owner on Jan 28, 2023. It is now read-only.
Remove legacy VTLB engine #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the new memory virtualization engine EPT2 (Extended Page Table) has been stable, the VTLB codes are deprecated. Change summary: * Removes the VTLB implementation and header files, and update the project files for 4 platforms; * Removes the related variables in other modules and redundant memory allocation for VTLB structure; * Adds the MMIO module to manage MMIO related functions. Signed-off-by: Wenchao Wang <[email protected]>
hyuan3
reviewed
Jun 3, 2021
| @@ -0,0 +1,95 @@ | |||
| /* | |||
There was a problem hiding this comment.
If mmio.h and mmio.c are not related with VTLB code clean, better submit in another commit.
There was a problem hiding this comment.
Thanks for your careful review. These MMIO functions had already existed in VTLB module before. All functions will be invoked by vCPU module currently, so they cannot be omitted because of build reason. All changes this time are atomic. For more details, see the comments at line 727 in previous vtlb.c.
hyuan3
approved these changes
Jun 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the new memory virtualization engine EPT2 (Extended Page Table) has been stable, the VTLB codes are deprecated.
Change summary: