Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix numpy.random.choice error in unwrap_error_phase_closure #989

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Apr 11, 2023

Description of proposed changes

  • unwrap_error_phase_closure: fix bug found by circle CI

    • use numpy random Generator syntax as recommended
    • fix the numpy.random.choice error by forcing the input arg as int type
  • README: fix broken links to Gamma, mintpy sub-modules/files due to "src" structure change.

  • utils.readfile.read_binary_file(): read data_type from Gamma .par file if exists

  • objects.sensor.ALOS2: more comments in different modes

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.

+ unwrap_error_phase_closure: fix bug found by circle CI
   - use numpy random Generator syntax as recommended
   - fix the numpy random choice error by forcing arg as int type

+ README: fix broken links to Gamma, mintpy sub-modules/files due to "src" structure change.

+ utils.readfile.read_binary_file(): read data_type from Gamma .par file if exists

+ objects.sensor.ALOS2: more comments in different modes
@yunjunz yunjunz merged commit 5ca554f into insarlab:main Apr 11, 2023
@yunjunz yunjunz deleted the bugfix branch April 11, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant