Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readfile: add auto_no_data_value() for known files #962

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Feb 20, 2023

Description of proposed changes

  • utils.readfile: add auto_no_data_value() for know file types: dense offsets from isce2/topsApp.py

  • utils.readfile: set the following functions as private, to discourage usage out of this sub-module:

    • _get_file_base_and_ext()
    • _sort_dataset_list2velocity()
    • _attribute_gamma2roipac()
    • _attribute_gmtsar2roipac()
  • view.read_data4figure(): do not print out msg while reading a list of 2D matrix (fine tune for view.py fails when using large multilook factor #950).

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

+ utils.readfile: add auto_no_data_value() for know file types: dense offsets from isce2/topsApp.py

+ utils.readfile: set the following functions as private, to discourage usage out of this sub-module:
   - `_get_file_base_and_ext()`
   - `_sort_dataset_list2velocity()`
   - `_attribute_gamma2roipac()`
   - `_attribute_gmtsar2roipac()`

+ view.read_data4figure(): do not print out msg while reading a list of 2D matrix
@yunjunz yunjunz merged commit cdfbb48 into insarlab:main Feb 20, 2023
@yunjunz yunjunz deleted the read branch February 20, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant