Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace expired numpy dtype deprecations (cont.) #960

Merged
merged 2 commits into from
Feb 18, 2023
Merged

replace expired numpy dtype deprecations (cont.) #960

merged 2 commits into from
Feb 18, 2023

Conversation

yjzhenglamarmota
Copy link
Contributor

@yjzhenglamarmota yjzhenglamarmota commented Feb 18, 2023 •
edited by yunjunz
Loading

Description of proposed changes

Changes due to numpy depreciation of np.int. Changes np.int to int in utils.py. See Previous Commit #934

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.

@yunjunz yunjunz changed the title changing np.int to int update numpy expired deprecations (cont.) Feb 18, 2023
@yunjunz yunjunz self-requested a review February 18, 2023 07:35
@yunjunz yunjunz changed the title update numpy expired deprecations (cont.) replace expired numpy dtype deprecations (cont.) Feb 18, 2023
yunjunz
yunjunz approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @yjzhenglamarmota for catching this!

@yunjunz yunjunz merged commit 6ed508c into insarlab:main Feb 18, 2023
@yjzhenglamarmota yjzhenglamarmota deleted the numpy_depreciation branch February 18, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjunz yunjunz yunjunz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yjzhenglamarmota @yunjunz