Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triplet design matrix speedup #650

Merged
merged 2 commits into from
Aug 28, 2021
Merged

Triplet design matrix speedup #650

merged 2 commits into from
Aug 28, 2021

Conversation

scottstanie
Copy link
Contributor

@scottstanie scottstanie commented Aug 28, 2021

Description of proposed changes

Speeds up the creation of the closure phase matrix in ifgramStack.get_design_matrix4triplet (discussed in #649). Should result in same output as previous implementation

Reminders

  • discussed in speeding up get_design_matrix4triplet? #649
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@yunjunz yunjunz self-requested a review August 28, 2021 23:30
@yunjunz yunjunz changed the title Triplet matrix speedup Triplet design matrix speedup Aug 28, 2021
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @scottstanie!

@yunjunz yunjunz merged commit f7b2b4f into insarlab:main Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants