-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace setup.py
with pyproject.toml
#1129
Conversation
+ add `tests/requirements.txt` file for test requirements + `requirements.txt`: move pre-commit into the `tests/requirements.txt` file + replace `setup.py` with `pyproject.toml`
I try to replace the old (test_mintpy) yunjunz:~>$ cd ~/tools/MintPy/
(test_mintpy) yunjunz:~/tools/MintPy>$ python -m pip install -e .
Obtaining file:///Users/yunjunz/tools/MintPy
Installing build dependencies ... done
Checking if build backend supports build_editable ... done
Getting requirements to build editable ... done
Preparing editable metadata (pyproject.toml) ... done
INFO: pip is looking at multiple versions of mintpy to determine which version is compatible with other requirements. This could take a while.
ERROR: Could not find a version that satisfies the requirement python>=3.6 (from mintpy) (from versions: none)
ERROR: No matching distribution found for python>=3.6 |
I think the By the way, had you considered bumping up the min python version? Both 3.6 and 3.7 are now in the end-of-life stage |
Thank you @scottstanie @avalentino for the quick fix and suggestions. I just bumped the min version to 3.8 as you suggested. I will look at the new syntax of 3.7 and 3.8 on another day to see what can be simplified in the code to leverage the new version! |
Description of proposed changes
add
tests/requirements.txt
file for test requirementsrequirements.txt
: move pre-commit into thetests/requirements.txt
filepyproject.toml
: add all the corresponding contents fromsetup.py
based on https://setuptools.pypa.io/en/latest/userguide/pyproject_config.htmldelete
setup.py
Reminders