Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_network: check nan values of coh/bperp in kept ifgrams #1108

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Oct 13, 2023

Description of proposed changes

  • plot_network: raise error for pairs with invalid coh/Bperp value, probably due to upstream insar processing issues. This is rarely seen, as reported in the google group.

  • utils.plot.auto_adjust_yaxis: ignore nan value in input data

    • use np.nanmin/nanmax() to replace min/max() to ignore nan values in the input data list
    • light refactoring to improve the readability
  • utils.plot.py: use consistent parameters/returns comment styles for all functions

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

+ plot_network: raise error for pairs with invalid coh/Bperp value, probably due to upstream insar processing issues. This is rarely seen.

+ utils.plot.auto_adjust_yaxis: ignore nan value in input data
  - use np.nanmin/nanmax() to replace min/max() to ignore nan values in the input data list
  - light refactoring to improve the readability
  - use consistent parameters/returns comment styles for all functions
@yunjunz yunjunz merged commit 2adeb67 into insarlab:main Oct 13, 2023
7 checks passed
@yunjunz yunjunz deleted the plot_net branch October 13, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant