Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach label to TVars mentioned in Effects #174

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Attach label to TVars mentioned in Effects #174

merged 1 commit into from
Oct 2, 2024

Conversation

jasagredo
Copy link
Contributor

@jasagredo jasagredo commented Oct 2, 2024 •
edited
Loading

This ensures that TxCommitted events will also print labels in the Effect. Otherwise we get something like

TxCommitted [Labelled TVarId 0 SharedState] ... Effect { writes = [TVarId 0] }

now it will print:

TxCommitted [Labelled TVarId 0 SharedState] ... Effect { writes = [Labelled TVarId 0 SharedState] }

bolt12
bolt12 approved these changes Oct 2, 2024
View reviewed changes
io-sim/src/Control/Monad/IOSimPOR/Internal.hs Outdated Show resolved Hide resolved
@jasagredo jasagredo force-pushed the js/label-effect-tvars branch 2 times, most recently from 3af7532 to 04ff96d Compare October 2, 2024 13:26
@jasagredo jasagredo added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 6d795fd Oct 2, 2024
20 checks passed
@jasagredo jasagredo deleted the js/label-effect-tvars branch October 2, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasagredo @bolt12