-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry On Error #924
Retry On Error #924
Conversation
I like the idea! @erlendp do you want to add more work here? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Any movement on this as it would be a very useful thing to have |
Only change I can see that would be needed, is that we limit the number of retries a render can have when erroring out. Worry could be that we get stuck in a render loop when it's dealing with an issue where an render is erroring out everytime |
@inlife On further review I propose the following changes
As it looks like OP has abandoned the change, I'll try and find time to do this. |
Awesome, will be looking forward. Big thanks for this |
@@ -246,7 +246,7 @@ Estimated date of change to the new behavior: 2023-06-01.\n`); | |||
}); | |||
|
|||
clearTimeout(timeoutID); | |||
return reject(new Error(outputStr || 'aerender.exe failed to render the output into the file due to an unknown reason')); | |||
return reject(new RenderProcessError(code, signal, outputStr || 'aerender.exe failed to render the output into the file due to an unknown reason')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aerender.exe is specific to Windows environnement. Nexrender run also on macOS 😉
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Occasionally the render process fails, and it would be desirable to allow the render to immediately try again under certain conditions, such as
aerender
exiting with a non-zero exit code.This PR adds the ability for the user to supply a custom
onShouldRetry
function to trigger a retry as required.