Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShowVariable functionality to infinity thrift #536

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

loloxwg
Copy link
Member

@loloxwg loloxwg commented Feb 2, 2024

This commit introduces the ShowVariable functionality to the infinity thrift RPC service. It includes changes across different python files to support the feature, including updates to request processing, as well as conversion of the results to a pandas Series.

What problem does this PR solve?

Add corresponding issue link with summary if exists -->

Issue link: #495

What is changed and how it works?

Code changes

  • Has Code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (knn performance test)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

This commit introduces the ShowVariable functionality to the infinity thrift
RPC service. It includes changes across different python files to support
the feature, including updates to request processing, as well as conversion
of the results to a pandas Series.
@JinHai-CN JinHai-CN added the ci PR can be test label Feb 2, 2024
@JinHai-CN JinHai-CN merged commit f22d3e2 into infiniflow:main Feb 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci PR can be test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants