Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with closing the session in remote debugging #450

Merged
merged 4 commits into from
May 14, 2021

Conversation

mlubimow
Copy link
Contributor

Fix for #289.

@inducer inducer merged commit a8813ad into inducer:main May 14, 2021
@inducer
Copy link
Owner

inducer commented May 14, 2021

LGTM! Thanks for your contribution.

@mlubimow
Copy link
Contributor Author

mlubimow commented May 16, 2021

@inducer Actually I realised recently that it's current behaviour also is not fully correct. I was focused on fixing the existing code more than the logic itself, and later I had second thoughts that on continue we probably don't want to close the session, because when in normal remote mode (reverse=False) it might be inconvenient to be required to telnet again if there is another breakpoint. Do you know if there is any hook that would allow us to run some code once the debugged process ends?

On the good side, with reverse=True its easy as its enough to add -k flag to nc (stty -echo -icanon && nc -l -p 6899 -k) to make continue to work as expected.

@inducer
Copy link
Owner

inducer commented May 16, 2021

Do you know if there is any hook that would allow us to run some code once the debugged process ends?

Possibly atexit?

@inducer
Copy link
Owner

inducer commented May 16, 2021

Actually I realised recently that it's current behaviour also is not fully correct.

Should we revert this in the meantime?

@mlubimow
Copy link
Contributor Author

@inducer Yeah atexit seems to be a way better idea, I will create another PR fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants