fix(helm): enable startup probe on server pod #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo0tzz
requested changes
Aug 27, 2024
willianpaixao
force-pushed
the
update-probes
branch
from
240cb64
to
d75a784
Compare
bo0tzz
requested changes
Aug 29, 2024
There was a problem hiding this comment.
This still doesn't seem to be working. The output I get is
...
readinessProbe:
failureThreshold: 3
httpGet:
path: /api/server-info/ping
port: http
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
startupProbe:
failureThreshold: 30
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
...which is missing the httpGet block.
willianpaixao
force-pushed
the
update-probes
branch
from
3371ef0
to
d920d6b
Compare
|
@bo0tzz I had to drop the use of anchors and fully write the startup probe. Please take a look now. |
willianpaixao
force-pushed
the
update-probes
branch
from
d920d6b
to
ffb7211
Compare
bo0tzz
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #102