fix(useDebounce): return type of callback #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #603 +/- ##
==========================================
+ Coverage 73.75% 73.80% +0.05%
==========================================
Files 67 67
Lines 1345 1344 -1
Branches 268 268
==========================================
Hits 992 992
+ Misses 352 351 -1
Partials 1 1
Continue to review full report at Codecov.
|
|
Outdated comment :) |
krijoh92
force-pushed
the
use-debounce-keep-type
branch
from
39e330d
to
c3e4984
Compare
|
I'm not 100% sure how to fix that build failure. Didn't seem like it originated from this code? |
|
This is an awesome PR @krijoh92 . 🙇🏽 |
|
@imbhargav5 build error is fixed! |
imbhargav5
approved these changes
Oct 14, 2021
|
🎉 This PR is included in version 5.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this way we the debounced function type is the same as the type of the callback we send in to
useDebounce.