Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: return type ReadonlyMap in useNativeMapState #1716

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

ChocolateLoverRaj
Copy link
Contributor

This will prevent bugs where people try to directly modify the map. By making it a ReadonlyMap, they will have TypeScript errors which will remind them to modify mapControls instead of map.

This will prevent bugs where people try to directly modify the map. By making it a `ReadonlyMap`, they will have TypeScript errors which will remind them to modify mapControls instead of map.
@codesandbox
Copy link

codesandbox bot commented Apr 22, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Apr 22, 2023

@ChocolateLoverRaj is attempting to deploy a commit to the Rooks Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (37c35ce) 90.13% compared to head (99fc590) 90.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1716   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files          98       98           
  Lines        6729     6729           
  Branches     1112     1111    -1     
=======================================
  Hits         6065     6065           
  Misses        662      662           
  Partials        2        2           
Impacted Files Coverage Δ
packages/rooks/src/hooks/useNativeMapState.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 6:40pm

@imbhargav5
Copy link
Owner

Love this @ChocolateLoverRaj ! Very useful. Could you add a changeset so I can publish this. You will find the details in the Contributing.md file. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants