Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis - Removed py34 #87

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Travis - Removed py34 #87

merged 1 commit into from
Apr 16, 2018

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Apr 16, 2018

Async syntax is first supported in py3.5

@ikalchev
Copy link
Owner

Sorry for that I only removed 3.4 from tox

@ikalchev ikalchev merged commit 4d79527 into ikalchev:dev Apr 16, 2018
@ikalchev
Copy link
Owner

This is strange, travis builds are failing sometimes, probably haven't mocked the aio/thread stuff. Need to check this.

anyway, thanks for this.

@cdce8p cdce8p deleted the patch-1 branch April 16, 2018 10:06
@cdce8p
Copy link
Contributor Author

cdce8p commented Apr 16, 2018

Since it fails for the accessory_driver, it might be related to the change to run_forever. If that's ok with you, I would like to redo / fix the tests in a separate PR. That way it might be a bit easier for me and I can include #83, #84, #85 and #86 in one. It would be great if #85 and #86 are merged of this.

I hope to get this done by the end of the day.

@ikalchev
Copy link
Owner

It’s fine, it could be that I haven’t patched the tests properly. I expect to have limited availability today and tomorrow, but will try to review/merge if something comes along

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants