Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: /meeting/materials splits out named sessions the same way /meeting/proceedings does #5715

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

pselkirk
Copy link
Collaborator

fixes #5653

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #5715 (147419b) into main (d595aac) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5715      +/-   ##
==========================================
- Coverage   88.73%   88.71%   -0.03%     
==========================================
  Files         285      285              
  Lines       39852    39860       +8     
==========================================
- Hits        35362    35361       -1     
- Misses       4490     4499       +9     
Impacted Files Coverage Δ
ietf/meeting/views.py 91.02% <100.00%> (+0.03%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

meeting.importantdate_set.create(name_id='revsub',date=date_today() + datetime.timedelta(days=20))
group = GroupFactory()
plain_session = SessionFactory(meeting=meeting, group=group)
named_session = SessionFactory(meeting=meeting, group=group, name='I Got a Name')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...like the singin' bird and the croakin' toad?

@rjsparks rjsparks merged commit 0567b3d into ietf-tools:main Jun 9, 2023
@pselkirk pselkirk deleted the fix-5653 branch June 9, 2023 20:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/meeting/materials should split out named sessions the same way /meeting/proceedings does
3 participants