Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types for useSSR #1121

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Update types for useSSR #1121

merged 1 commit into from
Jul 17, 2020

Conversation

gabeidx
Copy link

@gabeidx gabeidx commented May 22, 2020 •
edited
Loading

This PR updates the type definitions for the useSSR function, to closely match the withSSR definitions.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • documentation is changed or added

@coveralls
Copy link

coveralls commented May 22, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 95.775% when pulling 362a47a on gabrielizaias:patch-1 into 9f1d5d4 on i18next:master.

@adrai adrai requested a review from rosskevin May 23, 2020 05:36
rosskevin
rosskevin suggested changes May 23, 2020
View reviewed changes
Copy link
Collaborator

@rosskevin rosskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update or add usage tests in test/typescript to prevent future regressions.

@adrai
Copy link
Member

adrai commented Jul 3, 2020

Please update or add usage tests in test/typescript to prevent future regressions.

@GabrielIzaias Can you add tests as suggested?

@gabeidx
Copy link
Author

gabeidx commented Jul 3, 2020

@adrai I will try to come back to this next week.

@gabeidx
Copy link
Author

gabeidx commented Jul 13, 2020

Test added to test/typescript.

@gabeidx gabeidx requested a review from rosskevin July 13, 2020 15:38
@rosskevin rosskevin merged commit 35c60a0 into i18next:master Jul 17, 2020
@gabeidx gabeidx deleted the patch-1 branch December 31, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosskevin rosskevin rosskevin approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabeidx @coveralls @adrai @rosskevin