Ensure port clash is reported when engine-rpc-http-port clashes with default websocket port 8551 #3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default websocket port 8551 Fixes hyperledger#3721 Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
… switching feature off between unit tests Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
jflo
approved these changes
Apr 29, 2022
|
Kudos, SonarCloud Quality Gate passed! |
macfarla
added a commit
to macfarla/besu
that referenced
this pull request
May 10, 2022
…es with default websocket port 8551 (hyperledger#3750)" This reverts commit cacb837.
macfarla
added a commit
to macfarla/besu
that referenced
this pull request
May 10, 2022
…es with default websocket port 8551 (hyperledger#3750)" This reverts commit cacb837. Signed-off-by: Sally MacFarlane <[email protected]>
macfarla
added a commit
to macfarla/besu
that referenced
this pull request
May 10, 2022
…es with default websocket port 8551 (hyperledger#3750)" This reverts commit cacb837. Signed-off-by: Sally MacFarlane <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…default websocket port 8551 (hyperledger#3750) * Ensure port clash is reported when engine-rpc-http-port clashes with default websocket port 8551 * Remove one-way aspect of MergeConfigOptions.setMergeEnabled to enable switching feature off between unit tests Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed one-way aspect of MergeConfigOptions.setMergeEnabled to enable switching feature off between unit tests
Fixes #3721