Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common Bft forks schedule #2862

Merged
merged 21 commits into from
Oct 13, 2021
Merged

Common Bft forks schedule #2862

merged 21 commits into from
Oct 13, 2021

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Oct 7, 2021 •
edited
Loading

PR description

Create a common bft forks schedule that can be used between both ibft and qbft. This is necessary to add a bft transition for block period.

Fixed Issue(s)

Changelog

@jframe
Common Bft forks schedule
5c61071 
Signed-off-by: Jason Frame <[email protected]>
@jframe
rename test
5d1381c 
Signed-off-by: Jason Frame <[email protected]>
@jframe
spdx headers
8f0fa8a 
Signed-off-by: Jason Frame <[email protected]>
@jframe
move new common bft classes under the bft package
391fba6 
Signed-off-by: Jason Frame <[email protected]>
@jframe
spdx headers
bd9d997 
Signed-off-by: Jason Frame <[email protected]>
@jframe
spdx headers
d4694b3 
Signed-off-by: Jason Frame <[email protected]>
@jframe
fix unit test
aa93a71 
Signed-off-by: Jason Frame <[email protected]>
@jframe
more tests
df1ed75 
Signed-off-by: Jason Frame <[email protected]>
@jframe
spdx headers
7bfaf38 
Signed-off-by: Jason Frame <[email protected]>
@jframe
more tests
cce5e32 
Signed-off-by: Jason Frame <[email protected]>
@jframe
Merge branch 'main' into bft_transitions_schedule
8e6f0ba
@jframe jframe marked this pull request as ready for review October 11, 2021 06:39
siladu
siladu approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change to me and also cleans up some of the client code. Some questions and suggestions but nothing major.

...ft/src/main/java/org/hyperledger/besu/consensus/qbft/validator/ForkingValidatorProvider.java Outdated Show resolved Hide resolved
...ft/src/main/java/org/hyperledger/besu/consensus/qbft/validator/ForkingValidatorProvider.java Show resolved Hide resolved
consensus/qbft/src/main/java/org/hyperledger/besu/consensus/qbft/MutableQbftConfigOptions.java Show resolved Hide resolved
lucassaldanha
lucassaldanha approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Couple of minor comments.

config/src/main/java/org/hyperledger/besu/config/BftConfigOptions.java Outdated Show resolved Hide resolved
config/src/main/java/org/hyperledger/besu/config/JsonBftConfigOptions.java Show resolved Hide resolved
@jframe jframe merged commit 3996da8 into hyperledger:main Oct 13, 2021
@jframe jframe deleted the bft_transitions_schedule branch October 13, 2021 02:59
jflo pushed a commit to jflo/besu that referenced this pull request Oct 14, 2021
@jframe @jflo
Common Bft forks schedule (hyperledger#2862)
4754254 
Signed-off-by: Jason Frame <[email protected]>
jflo pushed a commit to jflo/besu that referenced this pull request Oct 14, 2021
@jframe @jflo
Common Bft forks schedule (hyperledger#2862)
99843c2 
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Oct 22, 2021
@jframe @garyschulte
Common Bft forks schedule (hyperledger#2862)
636455d 
Signed-off-by: Jason Frame <[email protected]>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@jframe @eum602
Common Bft forks schedule (hyperledger#2862)
83bca7c 
Signed-off-by: Jason Frame <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usmansaleem usmansaleem usmansaleem left review comments

@lucassaldanha lucassaldanha lucassaldanha approved these changes

@siladu siladu siladu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jframe @usmansaleem @lucassaldanha @siladu