Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Fantom Opera #248

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

joooeoeee
Copy link

I'm not sure if you want to add this chain now, as they are rebranding and changing their name. $FTM will become $S when Sonic goes live (no date yet), but I can modify the .yaml files once it's deprecated.

Description

Add Fantom Opera

Backward compatibility

No

Testing

yes, CLI

I'm not sure if you want to add this chain now, as they are rebranding and changing their name.
$FTM will become $S when Sonic goes live (no date yet), but I can modify the .yaml files once it's deprecated.
Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: 2ebb540

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperlane-xyz/registry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@paulbalaji paulbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also rename chains/fantomopera/ to chains/fantom/

chains/fantomopera/logo.svg Outdated Show resolved Hide resolved
chains/fantomopera/metadata.yaml Outdated Show resolved Hide resolved
chains/fantomopera/metadata.yaml Outdated Show resolved Hide resolved
chains/fantomopera/metadata.yaml Outdated Show resolved Hide resolved
Copy link
Author

@joooeoeee joooeoeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes done.

Added deployer info
Copy link
Author

@joooeoeee joooeoeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmrossy Thanks for the explanation!
I have updated the "deployer" section with my github details. Let me know if this works for you, otherwise I'll modify the metadata.yaml and remove the addresses.yaml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants