-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'Restart' RPC command #894
Fix 'Restart' RPC command #894
Conversation
Hello @m-seker 👋 I'm your friendly neighborhood bot and would like to say thank you for So that you and other users can test your changes more quickly, If you make changes to your PR, i create a new link to your workflow artifacts. Best regards, |
3182732
to
692359a
Compare
Here is your new link to your workflow artifacts. |
692359a
to
43a59fa
Compare
Here is your new link to your workflow artifacts. |
43a59fa
to
36ff93d
Compare
Here is your new link to your workflow artifacts. |
36ff93d
to
b66f7e1
Compare
Here is your new link to your workflow artifacts. |
You are the King of Fixing bugs!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works wonderfully. Many thanks
Here is your new link to your workflow artifacts. |
Summary
restart RPC fails because
execve
doesn't return and blocks the process. Hence we don't return a response to the caller. Also,hyperion->freeObjects()
is called on a totally wrong thread, which causes a crash.This PR introduces a different path for restarting Hyperion. It starts a new instance of Hyperion in a detached state with a special internal command line argument (--wait-hyperion). New instance sees that --wait-hyperion argument is set and waits until previous Hyperion exits. Old instance gracefully quits application. Then new instance continues with normal execution.
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: