fix: nbformat #10
Merged
fix: nbformat #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks very good. Thank you for the contribution. There are only a few linter errors left. Could you fix these? Then I would merge the pull request. |
iwilltry42
force-pushed
the
feat/nbformat
branch
from
30a28c4
to
ecb30e6
Compare
|
@hupe1980 done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation failed if Sources was a
[]string.This PR updates the structs with some more fields according to https://ipython.org/ipython-doc/3/notebook/nbformat.html and adds custom unmarshalling logic for the Source and Output Texts to always make it a single
string