Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added diffusers to conda-forge and updated README for installation instruction #129

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

sugatoray
Copy link
Contributor

Since adding a package to conda-forge cannot be done from this repository, it was taken care of by the following PR.

This PR updates the README to add conda install instruction.

Closes #126

@sugatoray
Copy link
Contributor Author

sugatoray commented Jul 22, 2022

It is available on conda-forge now!

Conda Version

$ conda search -c conda-forge diffusers
Loading channels: done
# Name                       Version           Build  Channel             
diffusers                      0.1.2    pyhd8ed1ab_0  conda-forge 

@sugatoray
Copy link
Contributor Author

sugatoray commented Jul 22, 2022

cc: @StoneCypher @patrickvonplaten @patil-suraj

@natolambert
Copy link
Contributor

(Accidentally ran the checks on my phone poking around l, though this looks like a useful addition) 🤦‍♂️

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 24, 2022

The documentation is not available anymore as the PR was closed or merged.

@sugatoray
Copy link
Contributor Author

Hi @natolambert,

I am not clear on if I have any actionable before this PR could be merged. Please let me know. Thank you.

@natolambert
Copy link
Contributor

I think @patrickvonplaten will look this week, or I can look then too. It was a really big push before the initial release, but I think this should be merged in shortly :)

@patrickvonplaten
Copy link
Contributor

Thanks a lot for your PR @sugatoray - @anton-l @patil-suraj can you maybe handle this? Also cc @LysandreJik

@sugatoray sugatoray changed the title Added diffusion to conda-forge and updated README for installation instruction Added diffusers to conda-forge and updated README for installation instruction Jul 29, 2022
@anton-l
Copy link
Member

anton-l commented Aug 3, 2022

Hi @sugatoray, sorry for the late reply! One request before we update the links: could you please add me and @patrickvonplaten to the maintainers list? That way we'll be able to trigger the conda package update right after we release a new version on PyPi (e.g. there's a 0.1.3 already). Thank you!

@anton-l anton-l self-requested a review August 3, 2022 10:46
@sugatoray
Copy link
Contributor Author

@anton-l Sure. Will add both of you as co-maintainers.

👉 Typically, there is a conda-forge bot that picks up new PyPI versions and pushes PR to the repository. There's also another bot that automerges when the conda-forge builds pass successfully.

👉 The only time you would need to manually intervene is when the listed dependencies on the conda-forge feedstock recipe are incomplete or need some manual tweaking/updating.

@anton-l
Copy link
Member

anton-l commented Aug 3, 2022

Awesome, thank you! 🤗

@anton-l anton-l merged commit 616c3a4 into huggingface:main Aug 3, 2022
@sugatoray
Copy link
Contributor Author

sugatoray commented Aug 4, 2022

This PR will add you as co-maintainers.

cc: @anton-l @patrickvonplaten

PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a conda install option for diffusers
5 participants