Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

softgpu: Correct accuracy of fog calculation #16005

Merged
merged 4 commits into from
Sep 11, 2022
Merged

softgpu: Correct accuracy of fog calculation #16005

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e3b73a
softgpu: Restrict sprite fast path to throughmode.
unknownbrackets Sep 11, 2022
b90fc71
softgpu: Correct accuracy of fog calculation.
unknownbrackets Sep 11, 2022
e723097
softjit: Implement accurate fog color blending.
unknownbrackets Sep 11, 2022
8c55e18
softgpu: Switch vert continue buffer to members.
unknownbrackets Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
softgpu: Restrict sprite fast path to throughmode. 
Its UV checks already should have generally, but let's be safe.  It
doesn't validate state like fog, etc.
  • Loading branch information
@unknownbrackets
unknownbrackets committed Sep 11, 2022
commit 2e3b73abaace9dbf10f467bd2f0443aba5923b49
4 changes: 1 addition & 3 deletions GPU/Software/RasterizerRectangle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,6 @@ static inline bool NoClampOrWrap(const RasterizerState &state, const Vec2f &tc)
return false;
if (state.samplerID.cached.sizes[0].w > 512 || state.samplerID.cached.sizes[0].h > 512)
return false;
if (!state.throughMode)
return tc.x <= 1.0f && tc.y <= 1.0f;
return tc.x <= state.samplerID.cached.sizes[0].w && tc.y <= state.samplerID.cached.sizes[0].h;
}

Expand All @@ -288,7 +286,7 @@ bool RectangleFastPath(const VertexData &v0, const VertexData &v1, BinManager &b
// Currently only works for TL/BR, which is the most common but not required.
bool orient_check = xdiff >= 0 && ydiff >= 0;
// We already have a fast path for clear in ClearRectangle.
bool state_check = !state.pixelID.clearMode && !state.samplerID.hasAnyMips && NoClampOrWrap(state, v0.texturecoords) && NoClampOrWrap(state, v1.texturecoords);
bool state_check = state.throughMode && !state.pixelID.clearMode && !state.samplerID.hasAnyMips && NoClampOrWrap(state, v0.texturecoords) && NoClampOrWrap(state, v1.texturecoords);
// This doesn't work well with offset drawing, see #15876. Through never has a subpixel offset.
bool subpixel_check = ((v0.screenpos.x | v0.screenpos.y | v1.screenpos.x | v1.screenpos.y) & 0xF) == 0;
if ((coord_check || !state.enableTextures) && orient_check && state_check && subpixel_check) {
Expand Down