Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softgpu: Fix viewport flag clean/dirty #15529

Merged
merged 2 commits into from
May 9, 2022

Conversation

unknownbrackets
Copy link
Collaborator

@unknownbrackets unknownbrackets commented May 8, 2022

Fixes Split/Second effects, see #15501. Such dumb mistakes... sorry.

-[Unknown]

Fixes crashes in GE debugger when viewing stencil.
@hrydgard
Copy link
Owner

hrydgard commented May 9, 2022

Good catches, no need to be sorry :)

@hrydgard hrydgard merged commit 64c71e9 into hrydgard:master May 9, 2022
@unknownbrackets unknownbrackets deleted the softgpu-dirty branch May 9, 2022 13:27
@Panderner
Copy link
Contributor

It's now fixed in software mode:
Screenshot (34)

But how about this?
Screenshot (37)
Screenshot (38)
Dump:
recording.zip

@unknownbrackets
Copy link
Collaborator Author

There's definitely a bug in softgpu lighting somewhere, I've seen this "inverted lighting" in the frame dump from #12507 as well (it's been there since before any state tracking too.) It's not related to this issue directly.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants