-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAXTER crash in softgpu, when frameskip is enabled #17021
Comments
I can't reproduce in other games - this is a bit strange. Can you try a Solution -> Clean, and then build again? Sometimes after refactoring, things get messed up. Doe sit happen in any other games? -[Unknown] |
v1.14.4-690-g2dc3a6b05 full debug log full debug log: |
Hm, weird. I'm not getting this crash. |
@hrydgard |
Yup, that does blow up immediately (tried frameskip 1). Weird! (Though frameskipping with the software renderer is kind of a weird combination, given how the software renderer is focused on accuracy, and skipping stuff certainly isn't accurate, and can break things... Maybe we shouldn't allow it) |
Data breakpoints to the rescue. It's the memset in SoftGPU::MarkDirty, for whatever reason it stomps outside the vramDirty_ array: It's only 2048 bytes long, but it writes 2048 bytes into it at an offset of 560. No idea why this would only happen when frameskipping... Aha... the plot thickens, note the SKIPFRAME check: Alright, seems we are estimating too large a region here. |
Thanks @hrydgard |
Game or games this happens in
NPUG80329
What area of the game / PPSSPP
After loading rom
What should happen
Don't crash
Logs
Platform
Windows
Mobile phone model or graphics card
Nvidia Geforce 710
PPSSPP version affected
v1.14.4-690-g2dc3a6b05-windows-amd64
Last working version
None
Graphics backend (3D API)
OpenGL / GLES
Checklist
The text was updated successfully, but these errors were encountered: