Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAXTER crash in softgpu, when frameskip is enabled #17021

Closed
2 of 5 tasks
sum2012 opened this issue Feb 27, 2023 · 9 comments · Fixed by #17028
Closed
2 of 5 tasks

DAXTER crash in softgpu, when frameskip is enabled #17021

sum2012 opened this issue Feb 27, 2023 · 9 comments · Fixed by #17028

Comments

@sum2012
Copy link
Collaborator

sum2012 commented Feb 27, 2023

Game or games this happens in

NPUG80329

What area of the game / PPSSPP

After loading rom

What should happen

Don't crash

Logs

1
2

Platform

Windows

Mobile phone model or graphics card

Nvidia Geforce 710

PPSSPP version affected

v1.14.4-690-g2dc3a6b05-windows-amd64

Last working version

None

Graphics backend (3D API)

OpenGL / GLES

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try without any cheats and without loading any save states.
  • Include logs or screenshots of issue.
@unknownbrackets
Copy link
Collaborator

I can't reproduce in other games - this is a bit strange. Can you try a Solution -> Clean, and then build again? Sometimes after refactoring, things get messed up.

Doe sit happen in any other games?

-[Unknown]

@sum2012
Copy link
Collaborator Author

sum2012 commented Feb 28, 2023

Yes,I try rebuild same,I forget another line of useful of crash trace.
I tested 20 games,only this game crash
3

I can't reproduce in other games - this is a bit strange. Can you try a Solution -> Clean, and then build again? Sometimes after refactoring, things get messed up.

Doe sit happen in any other games?

-[Unknown]

1

@sum2012
Copy link
Collaborator Author

sum2012 commented Feb 28, 2023

v1.14.4-690-g2dc3a6b05 full debug log full debug log:
https://gist.github.com/sum2012/b53fd1476c4239c77c47a4a7e99452ca

@hrydgard
Copy link
Owner

Hm, weird. I'm not getting this crash.

@sum2012
Copy link
Collaborator Author

sum2012 commented Feb 28, 2023

@hrydgard
frame skip 1 to 9
frame skip type:both type

@hrydgard
Copy link
Owner

hrydgard commented Feb 28, 2023

Yup, that does blow up immediately (tried frameskip 1). Weird!

(Though frameskipping with the software renderer is kind of a weird combination, given how the software renderer is focused on accuracy, and skipping stuff certainly isn't accurate, and can break things... Maybe we shouldn't allow it)

@hrydgard hrydgard added this to the v1.15.0 milestone Feb 28, 2023
@hrydgard hrydgard changed the title DAXTER crash in softgpu DAXTER crash in softgpu, when frameskip is enabled Feb 28, 2023
@hrydgard
Copy link
Owner

Heh, some .. interesting memory corruption is happening.

This is the SoftGPU object viewed in the debugger:
image

Something overwrote a whole bunch of pointers with 0303030303...

@hrydgard
Copy link
Owner

hrydgard commented Feb 28, 2023

Data breakpoints to the rescue. It's the memset in SoftGPU::MarkDirty, for whatever reason it stomps outside the vramDirty_ array:

image

It's only 2048 bytes long, but it writes 2048 bytes into it at an offset of 560.

No idea why this would only happen when frameskipping...

image

Aha... the plot thickens, note the SKIPFRAME check:

image

Alright, seems we are estimating too large a region here.

@sum2012
Copy link
Collaborator Author

sum2012 commented Mar 1, 2023

Thanks @hrydgard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants