Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filtering invoices feature #275

Merged
merged 8 commits into from
Mar 21, 2018
Merged

Added filtering invoices feature #275

merged 8 commits into from
Mar 21, 2018

Conversation

hql287
Copy link
Owner

@hql287 hql287 commented Mar 21, 2018

Related Issue

Issue #250

Motivation and Context

This PR allows the user to filter their invoices based on the invoice's status.

How Has This Been Tested?

  • A unit test has been added to make sure that when a filter is selected, Manta will display only the invoices with matched status.
  • Buttons label will be translated into the app language.

Screenshots (if appropriate):

screen shot 2018-03-21 at 14 21 10

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have included a migration scheme (If type of change is breaking change)

Optional Todos

  • Add animation
  • Persist filter state between page transition

@hql287 hql287 added the feature label Mar 21, 2018
@hql287 hql287 added this to the Build 07 - v1.1.5 milestone Mar 21, 2018
@hql287 hql287 self-assigned this Mar 21, 2018
@hql287 hql287 merged commit 0b27f2c into dev Mar 21, 2018
@hql287 hql287 deleted the filter-invoices branch March 21, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant